Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies glowie and supports-color, requires Node.js v20 #80

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Feb 7, 2025

Use util.styleText() instead.

We can wait for Node.js 18 EOL if you don't want bump requirements.

@silverwind
Copy link
Owner

silverwind commented Feb 7, 2025

I'm fine with requiring node 20 at this point.

@silverwind
Copy link
Owner

silverwind commented Feb 7, 2025

It seems to fail on bun:latest, but strangely enough only on Windows.

  SyntaxError: The requested module 'node:util' does not provide an export named 'styleText'

It seems as if the test does not actually execute in bun, but in Node.js v18.20.6.

@fisker
Copy link
Contributor Author

fisker commented Feb 7, 2025

It seems as if the test does not actually execute in bun, but in Node.js v18.20.6.

I think that's because execa("index.js") reads hashbang and use "node" to run js file.

@fisker
Copy link
Contributor Author

fisker commented Feb 7, 2025

BTW, there was a depreciation warning when using Bun, rexxars/registry-auth-token#49 should fix that.

@silverwind
Copy link
Owner

silverwind commented Feb 8, 2025

BTW, there was a depreciation warning when using Bun, rexxars/registry-auth-token#49 should fix that.

Thanks. I recall not updating registry-auth-token past v4 because of its bloated @pnpm/npm-conf dependency, see rexxars/registry-auth-token#39 (comment). Maybe we should make a lightweight .npmrc parser of our own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants